Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-outside-of-docker] - Fix externally-managed-environment python error for "bookworm" - solution to issue #1120 #1121

Merged
merged 13 commits into from
Sep 24, 2024
Merged

[docker-outside-of-docker] - Fix externally-managed-environment python error for "bookworm" - solution to issue #1120 #1121

merged 13 commits into from
Sep 24, 2024

Conversation

gauravsaini04
Copy link
Contributor

Feature Name

  • Docker-outside-of-docker

Description

Changelog

  • Added required code in install.sh file and added a test case scenario for testing it

Checklist

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner September 13, 2024 11:03
@gauravsaini04 gauravsaini04 mentioned this pull request Sep 13, 2024
Closed
@rubensa rubensa mentioned this pull request Sep 13, 2024
Closed
@samruddhikhandale samruddhikhandale linked an issue Sep 16, 2024 that may be closed by this pull request
[docker-outside-of-docker] Fix externally-managed-environment python error for "bookworm" #1120
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 19, 2024
View reviewed changes
src/docker-outside-of-docker/install.sh Show resolved Hide resolved
src/docker-outside-of-docker/install.sh Show resolved Hide resolved
src/docker-outside-of-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Sep 20, 2024
View reviewed changes
src/docker-outside-of-docker/install.sh Outdated Show resolved Hide resolved
src/docker-outside-of-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@samruddhikhandale samruddhikhandale merged commit f02df17 into devcontainers:main Sep 24, 2024
12 checks passed
@gauravsaini04 gauravsaini04 deleted the docker-outside-of-docker_#1120 branch September 25, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker-outside-of-docker] Fix externally-managed-environment python error for "bookworm"
2 participants
@gauravsaini04 @samruddhikhandale